I'm not married yet so I can only speak for engagement photos, but I was surprised by the photos I liked best. My favourites were just the ones where he captured us smiling at each other and you can see that we are happy.
probably my favourite, which we used on our save the dates:
but I also really love this one, because of the background:
I will say that the photos I really, really want on our actual wedding day, is the reaction when my bridal party and dad see me fully dressed for the first time.
I want to get the dress on with just my mum and the photographer (once I'm decent, lol!) and then get him to capture their reactions when I come out in the dress. My friend has that photo from her wedding (without asking, they just did it) and honestly seeing how happy we all are for her is one of my favourite shots.